New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for SVG type selectors in selector-type-case (#5712) #5717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hverlin Thank you! LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hverlin Thanks for the pull request. LGTM.
|
@jeddy3 I know but some projects might share files in the |
I see. No obvious right answer. You're welcome to open an issue for discussion. |
@hverlin @jeddy3
see https://developer.mozilla.org/en-US/docs/Web/SVG/Element#obsolete_and_deprecated_elements |
SVG elements with mixed case (e.g. "foreignObject") should be ignored by the "selector-type-case" rule.
Closes #5712
Added
.idea
to.gitignore
. Let me know if a separate PR should be done for this.